Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-5506 support directional selections #3095

Merged
merged 1 commit into from
Nov 25, 2024
Merged

CB-5506 support directional selections #3095

merged 1 commit into from
Nov 25, 2024

Conversation

devnaumov
Copy link
Member

The current implementation relies on from and to to represent the selection range in the editor. While this approach works for simple scenarios, it lacks the ability to properly handle selection direction and advanced cursor behavior. For example:

  • Directional Selections: When a user selects text in reverse (e.g., moving left while holding shift), from and to fail to retain which side of the selection the cursor (caret) is on.
  • Selection Extension: Keyboard shortcuts like cmd + shift + left require precise tracking of the fixed start (anchor) and current cursor position (head) to extend the selection correctly.

@devnaumov devnaumov self-assigned this Nov 22, 2024
@Wroud Wroud merged commit 6a82a31 into devel Nov 25, 2024
7 of 8 checks passed
@Wroud Wroud deleted the CB-5506-text-highlight branch November 25, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants