Fix sql-insert format emits NULL as 'None' #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Body: 1. Fix issue dbcli#1408 sql-insert format emits NULL as 'None'; 2. Fix DUAL displays as ""DUAL""; ==== End ====
Body: ==== End ====
Body: ==== End ====
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 84.15% 79.59% -4.57%
==========================================
Files 21 25 +4
Lines 2720 2984 +264
==========================================
+ Hits 2289 2375 +86
- Misses 431 609 +178
☔ View full report in Codecov by Sentry. |
3 tasks
j-bennet
reviewed
Jun 23, 2023
| except ModuleNotFoundError as e: | ||
| except ( | ||
| ModuleNotFoundError | ||
| ) as e: # ImportError for Python 2, ModuleNotFoundError for Python 3 |
There was a problem hiding this comment.
We don't support python 2.
There was a problem hiding this comment.
Sure, it was added by black 😂
j-bennet
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix sql-insert format emits NULL as 'None' (issue 1408).
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.