Permissions and Code Review/Tidy #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tempdoc endpoint (unused)
…dding todos for further review and future field removals
…to fee line items that were missed before
… required here) and fields to be removed
…p the same proposal id twice)
… field, and removed uncessary proposal applicant properties
…longer have unecessary dependency on super class (which has been removed)
…r issues or require additional information
…ssion and InternalProposalPermission
… type and user group membership
xzzy
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented permissions for approvers and assessors for each type of application.
Approval, proposal, and compliance permissions added. Internal users, changed to only include members of internal system user groups, have full read rights and can submit applications and compliances on an external user's behalf. Assessment and Approval rights are granted via their respective permissions by checking the application type of the proposal and the group membership of the given user. In-built IsAuthenticated permission is used where no group membership check is required, with external user access to records filtered by the applicant value (where applicable). DCV admissions still do not require authentication to submit.
Conducted comprehensive review of code, removing unused functions, commented out code, and ensuring all proper authorisation measure are in place.
A number of TODOs remain requiring additional information or related to other issues.