Update: correct auth check for surrender

dbca-wa · Oct 31, 2024 · 3115caa · 3115caa
1 parent 4f4b49d
commit 3115caa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/mooringlicensing/components/approvals/models.py b/mooringlicensing/components/approvals/models.py
@@ -925,7 +925,7 @@ def approval_surrender(self,request,details):
                     'details': details.get('surrender_details'),
                 }
 
-                if not (self.applicant_obj == request.user or not request.user in self.allowed_assessors):
+                if not (self.applicant_obj == request.user or request.user in self.allowed_assessors):
                     raise ValidationError("User not authorised to surrender approval")
 
                 today = timezone.now().date()