Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for antiword binary #88

Merged
merged 1 commit into from
Jun 18, 2016

Conversation

tommygnr
Copy link
Contributor

We are checking for the existence of the string ‘antiword: No such file
or directory’ not its absence so the test should be !== -1
If checking for === -1 we will also fail here when the binary exists
but the file is not a word doc (as is the case in the testForBinary
function)

Also add a check for antiword: not found as that is the error message
I receive on my platform (Ubuntu 16.04)

We are checking for the existence of the string ‘antiword: No such file
or directory’ not its absence so the test should be !== -1
If checking for === -1 we will also fail here when the binary exists
but the file is not a word doc (as is the case in the testForBinary
function)

Also add a check for `antiword: not found` as that is the error message
I receive on my platform (Ubuntu 16.04)
@dbashford
Copy link
Owner

Looks like this is off in a couple places, will probably simplify to not found as that is what I'm getting locally myself.

@dbashford dbashford merged commit 866f46c into dbashford:master Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants