fixes removal of double quotes #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have verified this locally. Going to merge this and get a test in place. Will probably cruise through some of the other tickets and patch a few more things up before releasing a version either later today or tomorrow. Thanks! |
dbashford
added a commit
that referenced
this pull request
Feb 25, 2016
fixes removal of double quotes
dbashford
added a commit
that referenced
this pull request
Feb 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
WHITELIST_PRESERVE_LINEBREAKSandWHITELIST_STRIP_LINEBREAKSwere removing double quotes, despite their appearance later being fixed byDOUBLE_QUOTES. The new regex values skip over the double quotes, just like they do for single quotes.