Fix "cb is not a function" error on RTFs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extraction of RTF files would previously fail with `TypeError`: "cb is not a function". This issue was caused by `html.extractFromText()` accepting an `options` object between the `data` and `cb` parameters (see [html.js:38](https://github.com/dbashford/textract/blob/416c55bf151c6ebe3cb8286c023e6fa10eaaa6df/lib/extractors/html.js#L38)) and `rtf.js` called it without the `options` parameter, resulting in `cb` being set to `undefined`.
dbashford
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraction of RTF files would previously fail with
TypeError: "cb is not a function".This issue was caused by
html.extractFromText()accepting anoptionsobject between thedataandcbparameters (see html.js:38) andrtf.jscalled it without theoptionsparameter, resulting incbbeing set toundefined.This error was mentioned in #149.