Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make long-running jobs not skip periods #404

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

SijmenHuizenga
Copy link
Collaborator

@SijmenHuizenga SijmenHuizenga commented Dec 20, 2020

As described in #304, jobs started on one day, running for so long they finish in the next day, the job wasn't being scheduled in the day the job finished, but the day after. The problem:

  • Job scheduled to run every day at 23:00
  • Job starts on day 1 at 23:00 and finishes the next day (day 2) at 00:03
  • The actual behaviour (before this change) is that the job is scheduled to run at day 3 on 23:00
    The expected behaviour (after this change) is that after finishing, the job is scheduled to run at day 2 at 23:00

@SijmenHuizenga SijmenHuizenga linked an issue Dec 20, 2020 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8228daf on SijmenHuizenga:patch-304 into 5033fbd on dbader:master.

@SijmenHuizenga SijmenHuizenga added this to the 1.0.0 milestone Jan 9, 2021
@SijmenHuizenga SijmenHuizenga merged commit 4a36c6e into dbader:master Jan 12, 2021
@SijmenHuizenga SijmenHuizenga deleted the patch-304 branch January 12, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long-running daily job skipped every other day
2 participants