BufferedMetricsLogger can't be used as a type

[jfirebaugh]

The following should work (TypeScript playground link):

import { BufferedMetricsLogger } from 'datadog-metrics'

function useLogger(logger: BufferedMetricsLogger) {
   logger.gauge('key', 0)
}

useLogger(new BufferedMetricsLogger())

However, it produces the following error:

'BufferedMetricsLogger' refers to a value, but is being used as a type here. Did you mean 'typeof BufferedMetricsLogger'?

(The suggestion the error message provides is not what I meant -- it generates different errors.)

[jfirebaugh]

The correct way to declare BufferedMetricsLogger in index.d.ts is given here:

export declare const BufferedMetricsLogger = loggers.BufferedMetricsLogger;
export declare type BufferedMetricsLogger = loggers.BufferedMetricsLogger;

[jfirebaugh]

Workaround until this is fixed

[Mr0grog]

Hey @jfirebaugh! 👋

Thanks for filing this! Guess I should have included a test of the types when I added support for generating them here. 😓 All the typings here are generated from JSDoc, so I need to figure out the right incantation to get it to do this. Will see what I can figure that out ASAP.

[jfirebaugh]

Hi Rob! Good to see you around. 😄

[Mr0grog]

@jfirebaugh I think I’ve got a working solution over in #120; are you able to test that that works for you, or do you need a pre-release build on NPM?

[jfirebaugh]

I think I would need a pre-release build. I tried putting "datadog-metrics": "dbader/node-datadog-metrics#119-if-you-want-types-you-probably-want-actual-types" in my package.json but the resulting installed package does not have declaration files. Nor does it have a tsconfig.json, so running cd node_modules/datadog-metrics && npm run build-types doesn't work either.

[Mr0grog]

@jfirebaugh OK, you should be able to test with 0.11.4-a1. (It’s clearly been too long since I published a pre-release on NPM, because I totally botched this one, hence version 0.11.4 instead of 0.11.3. 😩)

[jfirebaugh]

0.11.4-a.1 works, thanks!

[Mr0grog]

Sorry it took me a while to publish a production release here. This is now available in v0.11.4.