Skip to content

Commit

Permalink
Insert improperly compares number of columns and value columns
Browse files Browse the repository at this point in the history
Signed-off-by: Balint Balku <[email protected]>
  • Loading branch information
balint-balku-scraperapi committed Jan 4, 2021
1 parent 83c07df commit 701a528
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -447,10 +447,12 @@ var Base = Class.extend({

insert: function(tableName, valueArray, callback) {
var columnNameArray = {};
var numValueColumns;

if (arguments.length > 3 || Array.isArray(callback)) {
columnNameArray = valueArray;
valueArray = callback;
numValueColumns = Array.isArray(valueArray[0]) ? valueArray[0].length : valueArray.length;
} else {
var names;
if (Array.isArray(valueArray)) {
Expand All @@ -462,9 +464,11 @@ var Base = Class.extend({
for (var i = 0; i < names.length; ++i) {
columnNameArray[names[i]] = names[i];
}

numValueColumns = valueArray.length;
}

if (columnNameArray.length !== valueArray.length) {
if (columnNameArray.length !== numValueColumns) {
return Promise.reject(
new Error('The number of columns does not match the number of values.')
).nodeify(callback);
Expand Down

0 comments on commit 701a528

Please sign in to comment.