Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: unpin and upgrade packages #99

Merged
merged 3 commits into from
Oct 14, 2023
Merged

build: unpin and upgrade packages #99

merged 3 commits into from
Oct 14, 2023

Conversation

dazedbear
Copy link
Owner

Goal

  • unpin and upgrade packages to fix TypeError from react-icons
  • fix lint error from react hook usage

@codesandbox
Copy link

codesandbox bot commented Oct 14, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel
Copy link

vercel bot commented Oct 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dazedbear-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 9:04am

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2023
View reviewed changes
src/libs/client/hooks.ts
return false
}
const pathname = asPath.replace(/\?.*/gi, '') // remove query params
const regex = new RegExp(`${page}(\/.+)+`, 'i')

Check warning

Code scanning / Semgrep

Semgrep Finding: javascript.lang.security.audit.detect-non-literal-regexp.detect-non-literal-regexp Warning

RegExp() called with a page function argument, this might allow an attacker to cause a Regular Expression Denial-of-Service (ReDoS) within your application as RegExP blocks the main thread. For this reason, it is recommended to use hardcoded regexes instead. If your regex is run on user-controlled input, consider performing input validation or use a regex checking/sanitization library such as https://www.npmjs.com/package/recheck to verify that the regex does not appear vulnerable to ReDoS.
@dazedbear dazedbear merged commit 7e3a4b2 into main Oct 14, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 14, 2023
@semantic-release-bot
chore(release): 4.33.0 [skip ci]
3f92885 
## [4.33.0](v4.32.0...v4.33.0) (2023-10-14)

### Build

* unpin and upgrade packages ([#99](#99)) ([7e3a4b2](7e3a4b2))
@dazedbear dazedbear deleted the fix-react-icons branch October 14, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dazedbear