-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brew #46
Comments
@ivan-burazin please check Slack for this matter |
|
@idagelic brew install daytona/tap/daytonaio ? or some other shortener? |
@ivan-burazin Can't get it shorter than that right now - until we resolve the issue stopping us from getting Splitting it to two commands is an option: |
@idagelic which is standard when it comes to brew? I can update the instructions in the installation guide if splitting in two is the "better" option. Ideally since the docs are versioned, we should be instructing users to install the specific version of Daytona. Not sure if that's possible with brew; it's also a bit tricky with Nix. |
@osslate Afaic we can keep it simply |
What is the issues with TAP? |
I don't understand your question |
why cant it be brew install daytonaio/tap/daytona instead of brew install daytonaio/daytona/daytona |
As far as I understand, for illustration:
How it currently works:
And with the command you suggested:
Because of how Homebrew works, it seems common practice to name repositories and formulas in the standard |
Thanks for the explanation @osslate @ivan-burazin Yes, if we change the repository name from "homebrew-daytona" to "homebrew-tap", I just tried out this shortest option on my private acc: |
I'd opt to keep it as-is since it complies with Homebrew's standard. I'd also argue against changing the name as it'll break upgrades for people who've already done This discussion is out of scope for docs though; @ivan-burazin if you believe it should be changed, I suggest opening an issue in either https://github.com/daytonaio/homebrew-daytona/ or https://github.com/daytonaio/daytona/. If it changes, we can update the docs. From a docs perspective, do we want to keep the installation command as brew install daytonaio/daytona/daytona or split it in 2 and add upgrade instructions? i.e. brew tap daytonaio/daytona
brew install daytona |
brew tap daytonaio/daytona Is fine but would like to shorten the brew install daytonaio/daytona/daytona - > brew install daytonaio/tap/daytona if there are no hard arguments against. Lmk and will open a new issue on Daytona. thanks |
@ivan-burazin No problem, please open up an issue and add a "discussion" tag |
v0.18.0+ now live on Btw, you might have to run |
* Installation procedures split into partials * Installation guide split into sections based on OS (Linux, macOS, Windows) * Added uninstall/upgrade instructions for Homebrew * Added uninstall instructions for official method Fixes #54, fixes #46, fixes #45. Signed-off-by: Fionn Kelleher <[email protected]>
* Installation procedures split into partials * Installation guide split into sections based on OS (Linux, macOS, Windows) * Added uninstall/upgrade instructions for Homebrew * Added uninstall instructions for official method Fixes #54, fixes #46, fixes #45. Signed-off-by: Fionn Kelleher <[email protected]>
@idagelic can we get? brew install daytona so @osslate can update this everywhere?
The text was updated successfully, but these errors were encountered: