-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB query optimization and reducing sqlalchemy logs #575
Merged
shreyas-damle
merged 12 commits into
daxa-ai:main
from
shreyas-damle:shreyas-db-query-optimization
Sep 30, 2024
Merged
DB query optimization and reducing sqlalchemy logs #575
shreyas-damle
merged 12 commits into
daxa-ai:main
from
shreyas-damle:shreyas-db-query-optimization
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-damle
changed the title
Used in construct and reduced number of queries performed while getti…
DB query optimisation and reducing sqlalchemy logs
Sep 26, 2024
shreyas-damle
force-pushed
the
shreyas-db-query-optimization
branch
from
September 26, 2024 15:45
d526db2
to
fe53ef1
Compare
sridhar-daxa
changed the title
DB query optimisation and reducing sqlalchemy logs
DB query optimization and reducing sqlalchemy logs
Sep 27, 2024
dristysrivastava
requested changes
Sep 27, 2024
Raj725
previously approved these changes
Sep 27, 2024
Raj725
reviewed
Sep 27, 2024
dristysrivastava
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two fixes:
timeit
function for 4 entry point UI functions. This can be used to see how long did it take for backend processing for data generating for dashboard(loader and retriever), app details page(loader and retriever). Time tracking would be done only when logging level is debug.Query Optimisation Results:
Here’s a table comparing the execution times before and after:
SQLAlchemy logging improvement:
With logging level info:
With logging level as debug:
Fixed import warning while running UTs: