Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding anonymizeSnippets in reports config #569

Conversation

dristysrivastava
Copy link
Collaborator

@dristysrivastava dristysrivastava commented Sep 24, 2024

Changes:

  • Added anonymizedSnippets in `reports' section in config
    • If anonymizedSnippets will be there in both reprt and classifier. It will give following error:
Screenshot 2024-09-24 at 12 40 57
- If `anonymizedSnippets` will be there in `classifier`, following deprecation message will be shown:
Screenshot 2024-09-24 at 12 42 02
  • Updated config custom validation with pydanticV2 model validation

  • When pebblo server exists due to validation failure, now it will exits with failure message:

    • Before (Earlier it was failing with following messages)
Screenshot 2024-09-24 at 12 45 29
- After (Now)
Screenshot 2024-09-24 at 12 47 03
  • Updated /loader/doc API (for both file and DB) with latest config chaneg for anonymizeSnippets.
  • Updated Unit test cases for config validation

@dristysrivastava dristysrivastava requested review from shreyas-damle and srics and removed request for shreyas-damle September 24, 2024 07:19
pebblo/app/config/models.py Outdated Show resolved Hide resolved
pebblo/app/config/models.py Show resolved Hide resolved
pebblo/app/service/service.py Show resolved Hide resolved
tests/app/config/test_config_validation.py Show resolved Hide resolved
@dristysrivastava dristysrivastava marked this pull request as ready for review September 24, 2024 13:13
@shreyas-damle shreyas-damle merged commit b476d75 into daxa-ai:main Sep 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants