Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Formulae must have a ref! (ArgumentError)' #30

Closed
jfoster opened this issue Apr 6, 2021 · 1 comment
Closed

'Formulae must have a ref! (ArgumentError)' #30

jfoster opened this issue Apr 6, 2021 · 1 comment

Comments

@jfoster
Copy link
Contributor

jfoster commented Apr 6, 2021

Encountering this error when trying to use this on my personal homebrew tap, which includes both formulae and casks:

/usr/local/bin/brew tap jfoster/homebrew-tap
==> Tapping jfoster/tap
Cloning into '/usr/local/Homebrew/Library/Taps/jfoster/homebrew-tap'...
Tapped 5 casks and 7 formulae (44 files, 138.5KB).
/usr/local/bin/brew livecheck --quiet --newer-only --full-name --json --tap=jfoster/homebrew-tap
/usr/local/Homebrew/Library/Homebrew/formulary.rb:366:in `factory': Formulae must have a ref! (ArgumentError)
	from /usr/local/Homebrew/Library/Homebrew/formula.rb:1645:in `[]'
	from /Users/runner/work/_actions/dawidd6/action-homebrew-bump-formula/v3/main.rb:151:in `block in <module:Homebrew>'
	from /Users/runner/work/_actions/dawidd6/action-homebrew-bump-formula/v3/main.rb:142:in `each'
	from /Users/runner/work/_actions/dawidd6/action-homebrew-bump-formula/v3/main.rb:142:in `<module:Homebrew>'
	from /Users/runner/work/_actions/dawidd6/action-homebrew-bump-formula/v3/main.rb:18:in `<main>'
Error: Process completed with exit code 1.

Upon investigating this line it appears it simply does not expect a cask as an argument?
If this is intended behavior I'd suggested passing a --formula argument to livecheck to disable the checking of casks (I will submit a PR for this).
It would be awesome if this action could support casks, possibly making use of bump-cask-pr?

@dawidd6
Copy link
Owner

dawidd6 commented Apr 6, 2021

I don't think casks make use of livecheck. Given that much casks auto update, I don't know if it's a good idea to add this feature, but if anyone submits a PR for that I'll consider it.

dawidd6 added a commit that referenced this issue Apr 6, 2021
@dawidd6 dawidd6 closed this as completed Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants