Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 to test matrix #168

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Add Ruby 3.3 to test matrix #168

merged 1 commit into from
Dec 31, 2023

Conversation

davishmcclurg
Copy link
Owner

And update locked bundler to latest version that supports Ruby 2.5.

I had to add base64, bigdecimal, and csv to the gemspec because Ruby 3.3 now warns that they won't be available in the standard library in Ruby 3.4:

/Users/dharsha/repos/json_schemer/lib/json_schemer.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.
/Users/dharsha/repos/json_schemer/lib/json_schemer.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.

I'm not sure if they need version constraints or not, but I'm going to leave it unset for now.

minitest is also triggering a warning, but it looks like it'll be fixed in the next release: minitest/minitest#969

And update locked bundler to latest version that supports Ruby 2.5.

I had to add `base64`, `bigdecimal`, and `csv` to the gemspec because
Ruby 3.3 now warns that they won't be available in the standard library
in Ruby 3.4:

```
/Users/dharsha/repos/json_schemer/lib/json_schemer.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.
/Users/dharsha/repos/json_schemer/lib/json_schemer.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.
```

I'm not sure if they need version constraints or not, but I'm going to
leave it unset for now.

`minitest` is also triggering a warning, but it looks like it'll be
fixed in the next release: minitest/minitest#969
spec.add_development_dependency "i18n"
spec.add_development_dependency "i18n-debug"

spec.add_runtime_dependency "base64"
spec.add_runtime_dependency "bigdecimal"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davishmcclurg davishmcclurg merged commit b8adf14 into main Dec 31, 2023
68 checks passed
@davishmcclurg davishmcclurg deleted the ruby-3.3 branch December 31, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant