Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime parameters, support all config parameters #387

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Runtime parameters, support all config parameters #387

merged 3 commits into from
Dec 20, 2024

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Nov 28, 2024 •
edited
Loading

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Nov 28, 2024

Note: Currently Testing

@GeoDerp GeoDerp mentioned this pull request Nov 28, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
src/emhass/utils.py
Comment on lines +278 to +279
"Cant find associations file (associations.csv) in: "
+ str(emhass_conf["associations_path"])

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (private)
Loading
as clear text.
This expression logs
sensitive data (private)
Loading
as clear text.
@GeoDerp
Copy link
Contributor Author

GeoDerp commented Nov 28, 2024 •
edited
Loading

@davidusb-geek I added ruff extension for python file formatting. Let me know if you wish to choose another formatter or remove it all together.

If you like ruff, I can make a new PR after this with EMHASS auto formatted with ruff.

@davidusb-geek
Copy link
Owner

@davidusb-geek I added ruff extension for python file formatting. Let me know if you wish to choose another formatter or remove it all together.

If you like ruff, I can make a new PR after this with EMHASS auto formatted with ruff.

Lets go with ruff, I've never used but it seems neat and already used by a lot of major Python packages.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Nov 28, 2024

From my quick testing, I believe this PR is functional.

@GeoDerp GeoDerp mentioned this pull request Nov 28, 2024
Merged
@davidusb-geek davidusb-geek merged commit 12142ec into davidusb-geek:master Dec 20, 2024
12 of 14 checks passed
@davidusb-geek davidusb-geek mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeoDerp @davidusb-geek