web_server addon mode init data_path options param #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created from suggestion by @gieljnssns : Working on EMHASS-Add-on PR fr this now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 6 6
Lines 1707 1707
=======================================
Hits 1496 1496
Misses 211 211 ☔ View full report in Codecov by Sentry. |
|
Will let you know when I am happy with this. |
|
@davidusb-geek , there is an issue with the directory structure of the webserver on EMHASS-Add-on (since it uses its own ul). Will try and fix this and add it to this PR. |
|
Not my finest work. But it should work. @davidusb-geek |
davidusb-geek
approved these changes
Mar 10, 2024
|
Ok I will merge now and test later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.