Issue #154: "perform_backtest": "false" has no effect

[davidusb-geek]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d37aac3) 89.96% compared to head (6db8415) 89.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files           6        6           
  Lines        1644     1644           
=======================================
  Hits         1479     1479           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidusb-geek]

Hi @GeoDerp .
Will it be possible for you to check this?
This is related to #154.
I'm able to reproduce the issue by just summoning:

curl -i -H "Content-Type:application/json" -X POST -d '{"perform_backtest": "False"}' http://localhost:5000/action/forecast-model-fit

Which don't take the passed perform_backtest=False and performs the back-testing nevertheless

[davidusb-geek]

I added some tests to aid debug this in this PR but tests are passsing correctly

[GeoDerp]

I'll see if I can have a look tomorrow (it's 1am currently)

[GeoDerp]

I wonder if it's something dumb like:

curl -i -H "Content-Type:application/json" -X POST -d '{"perform_backtest": "false"}' http://localhost:5000/action/forecast-model-fit

Or

curl -i -H "Content-Type:application/json" -X POST -d '{"perform_backtest": False}' http://localhost:5000/action/forecast-model-fit

[davidusb-geek]

I've just tested this:

curl -i -H "Content-Type:application/json" -X POST -d '{"perform_backtest": "false"}' http://localhost:5000/action/forecast-model-fit

And still using the "perform_backtest": "true".

This one:

curl -i -H "Content-Type:application/json" -X POST -d '{"perform_backtest": False}' http://localhost:5000/action/forecast-model-fit

just exists as bad request

[GeoDerp]

I think its the:

emhass/src/emhass/machine_learning_forecaster.py

Line 166 in d37aac3

if perform_backtest:

Needs to be:

if perform_backtest is True:

for some reason.

[davidusb-geek]

I think its the:

emhass/src/emhass/machine_learning_forecaster.py

Line 166 in d37aac3

if perform_backtest:

Needs to be:

if perform_backtest is True:

for some reason.

This is very strage. That is basic Python, I don't see how could that not work.
But I will test it with your PR.