Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional bugs #164

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix optional bugs #164

merged 2 commits into from
Jan 30, 2024

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Jan 30, 2024

No description provided.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 30, 2024

wanted to get this out as quickly as possible. currently testing now and confirming there are not more related issues . (which there is)

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d90912) 88.54% compared to head (c019921) 88.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files           6        6           
  Lines        1668     1668           
=======================================
  Hits         1477     1477           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidusb-geek davidusb-geek merged commit f78158e into davidusb-geek:master Jan 30, 2024
13 checks passed
@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 30, 2024

After spending like two hrs tracing back the trace, finding that other parameter that should have been a list. Only after I did the pull request, I saw your message about the other broken parameter 🤦🏼
Oh well, at least I learnt more.

@davidusb-geek
Copy link
Owner

Ok no worries. Thanks for the effort.
I did reverted types for load_negative and set_zero_min that you changed to lists in your PR.
We are not expecting lists for these parameters.
I just released a new patched version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants