-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make options optional #158
Conversation
@davidusb-geek sorry was developing this and saw all you done with the pull requests. I think this code could be necessary for the emhass-add-on davidusb-geek/emhass-add-on#69 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 6 6
Lines 1491 1491
=======================================
Hits 1333 1333
Misses 158 158 ☔ View full report in Codecov by Sentry. |
@davidusb-geek sorry about that. I hope this all gets to you in time. |
About my last commit. Got pytest tab inside of vscode working (inside of the vs-code virtual environment). There is also now a vs-code task to compile emhass, and two launch commands to debug emhass with and without add-on. Add-on launch requires key and url inserted in the launch.json to operate however. |
Ok merging and then testing this locally. |
Well don't about this I just found how to select the configuration that I want to run. It's in the debug pane to the left on VScode |
The thought would be that someone would pull the code, run it in vscode Dev container. (After vs code asks on the bottom right) Then on the left tab as you mentioned run the desired launch function and have the gui give out the results. The variable section when it fails is my favourite part. Also the pytest panel (I believe ok the left tab below) should also work now too. I'll have a read of that link today. 👍 |
Home assistant optional parameters support