Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options optional #158

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Make options optional #158

merged 4 commits into from
Jan 28, 2024

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Jan 28, 2024

Home assistant optional parameters support

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 28, 2024

@davidusb-geek sorry was developing this and saw all you done with the pull requests. I think this code could be necessary for the emhass-add-on davidusb-geek/emhass-add-on#69

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a6b492) 89.40% compared to head (8e447d9) 89.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files           6        6           
  Lines        1491     1491           
=======================================
  Hits         1333     1333           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 28, 2024

@davidusb-geek sorry about that. I hope this all gets to you in time.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 28, 2024

About my last commit. Got pytest tab inside of vscode working (inside of the vs-code virtual environment). There is also now a vs-code task to compile emhass, and two launch commands to debug emhass with and without add-on. Add-on launch requires key and url inserted in the launch.json to operate however.
Hope it helps.

@davidusb-geek
Copy link
Owner

Ok merging and then testing this locally.
I did tried the new launch.json but I did not understand how to launch a specific cofiguration inside the launch.json.
Do you know how to do this?

@davidusb-geek davidusb-geek merged commit c0d2adf into davidusb-geek:master Jan 28, 2024
13 checks passed
@davidusb-geek
Copy link
Owner

Ok merging and then testing this locally. I did tried the new launch.json but I did not understand how to launch a specific cofiguration inside the launch.json. Do you know how to do this?

Well don't about this I just found how to select the configuration that I want to run. It's in the debug pane to the left on VScode
Well explained here: https://gigi.nullneuron.net/gigilabs/working-with-vs-code-launch-configurations/

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 28, 2024

The thought would be that someone would pull the code, run it in vscode Dev container. (After vs code asks on the bottom right)
Press ctrl+ship+p, select run task, select build emhass

Then on the left tab as you mentioned run the desired launch function and have the gui give out the results. The variable section when it fails is my favourite part.

Also the pytest panel (I believe ok the left tab below) should also work now too.

I'll have a read of that link today. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants