-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation integration #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo fix
Added computed variables definitions (thanks to rcruikshank for the list) and corresponding published sensors
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 6 6
Lines 1420 1420
=======================================
Hits 1252 1252
Misses 168 168 ☔ View full report in Codecov by Sentry. |
Added P_batt variable
Added SOC_opt
Moved the variables definition to a better section
moved the new section with computed variables to a better section
error fix
|
||
Below you can find a list of the variables resulting from EMHASS computation, showed in the charts, and then published to Home Assistant through the ```publish_data``` command: | ||
|
||
| EMHASS varibale | Definition | Home Assistant published sensor | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "variable"
davidusb-geek
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements (typos) and integrations to the documentation (also thanks to @rcruikshank)
Thanks!