Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation integration #136

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Documentation integration #136

merged 8 commits into from
Dec 15, 2023

Conversation

g1za
Copy link
Contributor

@g1za g1za commented Dec 12, 2023

Some improvements (typos) and integrations to the documentation (also thanks to @rcruikshank)
Thanks!

g1za added 3 commits October 19, 2023 00:52
Added computed variables definitions (thanks to rcruikshank for the list) and corresponding published sensors
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bec6f76) 88.16% compared to head (83f25ce) 88.16%.

Files Patch % Lines
src/emhass/command_line.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files           6        6           
  Lines        1420     1420           
=======================================
  Hits         1252     1252           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

g1za added 5 commits December 13, 2023 00:35
Added P_batt variable
Added SOC_opt
Moved the variables definition to a better section
moved the new section with computed variables to a better section
error fix

Below you can find a list of the variables resulting from EMHASS computation, showed in the charts, and then published to Home Assistant through the ```publish_data``` command:

| EMHASS varibale | Definition | Home Assistant published sensor |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "variable"

@davidusb-geek davidusb-geek merged commit 05c7ed1 into davidusb-geek:master Dec 15, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants