Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Fixes: Default height, ability to change zoom and vue2-leaflet upgrade #11

Merged
merged 3 commits into from
Jan 27, 2019

Conversation

bomshteyn
Copy link
Contributor

While configuring the plugin for my use case i have run into few issues

  • if not setting ->height() the map was not showing up at all as the default height of 300px was only being set if the ->height() was called but without a param
  • needed ability to zoom in to street level by default

This pull request fixes both of these plus upgrades underlying vue2-leaflet

… and getting blank instead

* fix: fitBounds was breaking zoom property and setting it to maxZoom
* Add ability to pass zoom level as an option
@bomshteyn bomshteyn mentioned this pull request Dec 25, 2018
@bomshteyn
Copy link
Contributor Author

@davidpiesse the reason i am calling the zoom method after fitBounds is because fitBounds doesn't respect zoom property and was setting it to maxZoom.

So for example if the initial zoom was set to 8 and maxzoom inside the fitBounds function was passed as 16 it would change the zoom to 16.

@Zen0x7
Copy link

Zen0x7 commented Dec 26, 2018

Nice dude! 🎉🎉🎉

édít
This will reduce too much my app load time...

@davidpiesse
Copy link
Owner

Hi there!

Thanks for this. Been very busy recently with paying work so have not had time to merge in these changes. I am monitoring it and it all makes sense.

Hopefully I can bring it in soon 😄

D

@bomshteyn
Copy link
Contributor Author

Hi, any timeline on this?

@davidpiesse davidpiesse merged commit f116ab2 into davidpiesse:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants