Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Protobuf: Remove java 7 compatibility mode
This is a workaround to suppress annoying warning: warning: -parameters is not supported for target value 1.7. Use 1.8 or later. wenn building protobuf_java. The full story can be seen in this Bazel issue: [1]. I tried hard to avoid the need for patching Protobuf on fetch, by trying to remove Java 7 compatibility mode upstrea, that was rejected: [2]. moreover, I tried hard and spent quite some time to fix the problem in Bazel: [3], in non-invasive way, but this PR was as well rejected. The next natural approach is to just patch the Protobuf source during the fetch operation. Needless to say, that the patching during the fetch has its own disavdantages, that the patch would probably neeed to be updated on every Protobuf upgrade. But what can you do? The developers are complaining and writing the issues in every issue tracker, as here in Gerrit Code Review project: [4]. [1] protocolbuffers/protobuf#6711 [3] bazelbuild/bazel#9494 [3] protocolbuffers/protobuf#6711 [4] https://bugs.chromium.org/p/gerrit/issues/detail?id=11102
- Loading branch information