-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use dts-bundle-generator for rollup ts files #414
fix: use dts-bundle-generator for rollup ts files #414
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
📦 Bundle size (Angular v17)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v16)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v15)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
🎉 This PR is included in version 1.0.0-alpha.47 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed changes
Rolls up all Typescript definition for every
ngx-meta
entrypoint usingdts-bundle-generator
In order to avoid exporting imported types from other entrypoints (such as
json-ld
importing something fromcore
)exportReferencedTypes
is set tofalse
This project was chosen instead of
rollup-plugin-dts
, given the project is currently on maintenance mode since July 2023Efforts started with that plugin though, so a PR will be opened just to show how it could be implemented.
Other options analyzed were less maintained and less popular projects. So they were discarded.
Quick reminders
Fixes issue #411