Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dts-bundle-generator for rollup ts files #414

Conversation

davidlj95
Copy link
Owner

Proposed changes

Rolls up all Typescript definition for every ngx-meta entrypoint using dts-bundle-generator

In order to avoid exporting imported types from other entrypoints (such as json-ld importing something from core) exportReferencedTypes is set to false

This project was chosen instead of rollup-plugin-dts, given the project is currently on maintenance mode since July 2023

Efforts started with that plugin though, so a PR will be opened just to show how it could be implemented.

Other options analyzed were less maintained and less popular projects. So they were discarded.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Fixes issue #411

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 enabled auto-merge (squash) March 10, 2024 01:26
@davidlj95 davidlj95 merged commit 05fbcf5 into main Mar 10, 2024
14 checks passed
@davidlj95 davidlj95 deleted the stacked/fix-use-dts-bundle-generator-to-generate-bundled-ts-files branch March 10, 2024 01:27
Copy link

📦 Bundle size (Angular v17)

Git ref: 41d01663e44d48e4edbd2a204aabb18b2e701b6d

Module file Size Base size Difference
ngx-meta-core.mjs 3048 bytes (3.0KiB) Not available Not available
ngx-meta-json-ld.mjs 226 bytes (226B) Not available Not available
ngx-meta-open-graph.mjs 888 bytes (888B) Not available Not available
ngx-meta-routing.mjs 839 bytes (839B) Not available Not available
ngx-meta-standard.mjs 768 bytes (768B) Not available Not available
ngx-meta-twitter-card.mjs 488 bytes (488B) Not available Not available
Total 6257 bytes (6.2KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

📦 Bundle size (Angular v16)

Git ref: 41d01663e44d48e4edbd2a204aabb18b2e701b6d

Module file Size Base size Difference
ngx-meta-core.mjs 3460 bytes (3.4KiB) Not available Not available
ngx-meta-json-ld.mjs 392 bytes (392B) Not available Not available
ngx-meta-open-graph.mjs 1227 bytes (1.2KiB) Not available Not available
ngx-meta-routing.mjs 1015 bytes (1015B) Not available Not available
ngx-meta-standard.mjs 885 bytes (885B) Not available Not available
ngx-meta-twitter-card.mjs 648 bytes (648B) Not available Not available
Total 7627 bytes (7.5KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

📦 Bundle size (Angular v15)

Git ref: 41d01663e44d48e4edbd2a204aabb18b2e701b6d

Module file Size Base size Difference
ngx-meta-core.mjs 3460 bytes (3.4KiB) Not available Not available
ngx-meta-json-ld.mjs 392 bytes (392B) Not available Not available
ngx-meta-open-graph.mjs 1227 bytes (1.2KiB) Not available Not available
ngx-meta-routing.mjs 1015 bytes (1015B) Not available Not available
ngx-meta-standard.mjs 885 bytes (885B) Not available Not available
ngx-meta-twitter-card.mjs 648 bytes (648B) Not available Not available
Total 7627 bytes (7.5KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

🎉 This PR is included in version 1.0.0-alpha.47 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple imports are suggested, just one is the recommended
1 participant