Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sort package.json files #1032

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Nov 12, 2024

Issue or need

package.json run scripts are not ordered. So some useful scripts may not be seen due to that.

Proposed changes

Add linter rule to sort package.json

Also:

  • Remove unneeded ng run script
  • Replace cache-clean run script only used in JetBrains IDE run configs by exec ng in those instead
  • Add validate script for Renovate. Rename them to use : notation

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 enabled auto-merge (squash) November 12, 2024 21:00
@davidlj95 davidlj95 disabled auto-merge November 12, 2024 21:01
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (69edb48) to head (dea5226).
Report is 12 commits behind head on main.

Current head dea5226 differs from pull request most recent head 802d2c9

Please upload reports for the commit 802d2c9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1032   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           89        89           
  Lines          395       395           
  Branches        55        55           
=========================================
  Hits           395       395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

📦 Bundle size (Angular v16)

Git ref: dea522667fca3d277b3d1a098a247dd7725560c8

Module file Size Base size Difference
ngx-meta-core.mjs 3467 bytes (3.4KiB) 3467 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 201 bytes (201B) 201 bytes (201B) No change
ngx-meta-open-graph.mjs 870 bytes (870B) 870 bytes (870B) No change
ngx-meta-routing.mjs 379 bytes (379B) 379 bytes (379B) No change
ngx-meta-standard.mjs 808 bytes (808B) 808 bytes (808B) No change
ngx-meta-twitter-card.mjs 448 bytes (448B) 448 bytes (448B) No change
Total 6173 bytes (6.1KiB) 6173 bytes (6.1KiB) No change

Copy link

📦 Bundle size (Angular v18)

Git ref: dea522667fca3d277b3d1a098a247dd7725560c8

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 217 bytes (217B) 217 bytes (217B) No change
ngx-meta-open-graph.mjs 931 bytes (931B) 931 bytes (931B) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 857 bytes (857B) 857 bytes (857B) No change
ngx-meta-twitter-card.mjs 487 bytes (487B) 487 bytes (487B) No change
Total 6091 bytes (6.0KiB) 6091 bytes (6.0KiB) No change

Copy link

📦 Bundle size (Angular v17)

Git ref: dea522667fca3d277b3d1a098a247dd7725560c8

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 217 bytes (217B) 217 bytes (217B) No change
ngx-meta-open-graph.mjs 931 bytes (931B) 931 bytes (931B) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 857 bytes (857B) 857 bytes (857B) No change
ngx-meta-twitter-card.mjs 487 bytes (487B) 487 bytes (487B) No change
Total 6091 bytes (6.0KiB) 6091 bytes (6.0KiB) No change

Copy link

📦 Bundle size (Angular v15)

Git ref: dea522667fca3d277b3d1a098a247dd7725560c8

Module file Size Base size Difference
ngx-meta-core.mjs 3384 bytes (3.4KiB) 3384 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 206 bytes (206B) 206 bytes (206B) No change
ngx-meta-open-graph.mjs 870 bytes (870B) 870 bytes (870B) No change
ngx-meta-routing.mjs 373 bytes (373B) 373 bytes (373B) No change
ngx-meta-standard.mjs 808 bytes (808B) 808 bytes (808B) No change
ngx-meta-twitter-card.mjs 448 bytes (448B) 448 bytes (448B) No change
Total 6089 bytes (6.0KiB) 6089 bytes (6.0KiB) No change

Use `exec` for JetBrains run configurations
@davidlj95 davidlj95 force-pushed the stacked/build-sort-package.json-files branch from dea5226 to 802d2c9 Compare November 12, 2024 21:09
@davidlj95 davidlj95 merged commit f1f9420 into main Nov 12, 2024
@davidlj95 davidlj95 deleted the stacked/build-sort-package.json-files branch November 12, 2024 21:09
Copy link

🎉 This PR is included in version 1.0.0-beta.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant