Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not publish tarball inside package #1027

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

davidlj95
Copy link
Owner

Issue or need

After inspecting randomly the contents of the published package, noticed that the tarball is inside the package! So package is contained within the package xD

Proposed changes

Do not include tarballs from distribution directory

Considered also putting the tarball in another place. But dist dir feels most appropriate

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) November 11, 2024 21:34
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8725c28) to head (0e39b37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           89        89           
  Lines          395       395           
  Branches        55        55           
=========================================
  Hits           395       395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit f655141 into main Nov 11, 2024
35 checks passed
@davidlj95 davidlj95 deleted the stacked/fix-do-not-publish-tarball-inside-package branch November 11, 2024 21:40
Copy link

📦 Bundle size (Angular v15)

Git ref: 0e39b37dd58638bd21f979bc94b9354c69f5237f

Module file Size Base size Difference
ngx-meta-core.mjs 3384 bytes (3.4KiB) 3384 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 206 bytes (206B) 206 bytes (206B) No change
ngx-meta-open-graph.mjs 870 bytes (870B) 870 bytes (870B) No change
ngx-meta-routing.mjs 373 bytes (373B) 373 bytes (373B) No change
ngx-meta-standard.mjs 808 bytes (808B) 808 bytes (808B) No change
ngx-meta-twitter-card.mjs 448 bytes (448B) 448 bytes (448B) No change
Total 6089 bytes (6.0KiB) 6089 bytes (6.0KiB) No change

Copy link

📦 Bundle size (Angular v17)

Git ref: 0e39b37dd58638bd21f979bc94b9354c69f5237f

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 217 bytes (217B) 217 bytes (217B) No change
ngx-meta-open-graph.mjs 931 bytes (931B) 931 bytes (931B) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 857 bytes (857B) 857 bytes (857B) No change
ngx-meta-twitter-card.mjs 487 bytes (487B) 487 bytes (487B) No change
Total 6091 bytes (6.0KiB) 6091 bytes (6.0KiB) No change

Copy link

📦 Bundle size (Angular v16)

Git ref: 0e39b37dd58638bd21f979bc94b9354c69f5237f

Module file Size Base size Difference
ngx-meta-core.mjs 3467 bytes (3.4KiB) 3467 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 201 bytes (201B) 201 bytes (201B) No change
ngx-meta-open-graph.mjs 870 bytes (870B) 870 bytes (870B) No change
ngx-meta-routing.mjs 379 bytes (379B) 379 bytes (379B) No change
ngx-meta-standard.mjs 808 bytes (808B) 808 bytes (808B) No change
ngx-meta-twitter-card.mjs 448 bytes (448B) 448 bytes (448B) No change
Total 6173 bytes (6.1KiB) 6173 bytes (6.1KiB) No change

Copy link

📦 Bundle size (Angular v18)

Git ref: 0e39b37dd58638bd21f979bc94b9354c69f5237f

Module file Size Base size Difference
ngx-meta-core.mjs 0 bytes (0B) 3205 bytes (3.2KiB) -100.00%: -3205 bytes (-3.2KiB)
ngx-meta-json-ld.mjs 0 bytes (0B) 217 bytes (217B) -100.00%: -217 bytes (-217B)
ngx-meta-open-graph.mjs 0 bytes (0B) 931 bytes (931B) -100.00%: -931 bytes (-931B)
ngx-meta-routing.mjs 0 bytes (0B) 394 bytes (394B) -100.00%: -394 bytes (-394B)
ngx-meta-standard.mjs 0 bytes (0B) 857 bytes (857B) -100.00%: -857 bytes (-857B)
ngx-meta-twitter-card.mjs 0 bytes (0B) 487 bytes (487B) -100.00%: -487 bytes (-487B)
ngx-meta-core.mjs 3205 bytes (3.2KiB) 0 bytes (0B) %: 3205 bytes (3.2KiB)
ngx-meta-json-ld.mjs 217 bytes (217B) 0 bytes (0B) %: 217 bytes (217B)
ngx-meta-open-graph.mjs 931 bytes (931B) 0 bytes (0B) %: 931 bytes (931B)
ngx-meta-routing.mjs 394 bytes (394B) 0 bytes (0B) %: 394 bytes (394B)
ngx-meta-standard.mjs 857 bytes (857B) 0 bytes (0B) %: 857 bytes (857B)
ngx-meta-twitter-card.mjs 487 bytes (487B) 0 bytes (0B) %: 487 bytes (487B)
Total 6091 bytes (6.0KiB) 6091 bytes (6.0KiB) No change

Copy link

🎉 This PR is included in version 1.0.0-beta.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant