-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not publish tarball inside package #1027
fix: do not publish tarball inside package #1027
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 395 395
Branches 55 55
=========================================
Hits 395 395 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
🎉 This PR is included in version 1.0.0-beta.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
After inspecting randomly the contents of the published package, noticed that the tarball is inside the package! So package is contained within the package xD
Proposed changes
Do not include tarballs from distribution directory
Considered also putting the tarball in another place. But
dist
dir feels most appropriateQuick reminders