-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: just fetch PR commits when linting messages #1026
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
📦 Bundle size (Angular v18)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v16)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v17)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v15)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 395 395
Branches 55 55
=========================================
Hits 395 395 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 1.0.0-beta.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
After reviewing how the linting tooling is setup to update another repository, saw that
fetch-depth
is set to0
aka fetch everything. This is too much though. We only need the commits from the PR!Proposed changes
Use several tricks to just fetch the appropriate depth:
+ 1
so just one will be fetched. As expected in themain
case. The +1 is needed as otherwise the range doesn't exist given the pull request base isn't fetched, but it's included in the range. It has to be included, as the start from the range is needed, despite not inspected.commitlint --last
instead ofcommitlint --from HEAD~1
. As if just fetching last commit inmain
, theHEAD~1
doesn't exist. As explained above.Simulated both cases and everything goes fine
Quick reminders