Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add script to rehearse a release publish #1012

Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Oct 30, 2024

Issue or need

After trying publishing to a local registry in order to test #1005 locally, found out that the process to publish to a local private registry can be improved.

It implies:

  • Altering Semantic Release configurations in .releaserc.js:
    • No GitHub plugin if using . as repository
    • No release notes plugin if using . as repository
  • Registry set to local one, not real one
  • Disable provenance

Proposed changes

Add a script to automate and ensure all conditions to avoid pitfalls.

Update contributing docs to refer to the script & update steps.

Move docs notes into the script / config. Out of contributing docs, to make them lighter.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ccb2c12) to head (b938588).
Report is 17 commits behind head on main.

Current head b938588 differs from pull request most recent head 2b3eab3

Please upload reports for the commit 2b3eab3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1012   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           89        89           
  Lines          395       395           
  Branches        55        55           
=========================================
  Hits           395       395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 30, 2024

📦 Bundle size (Angular v18)

Git ref: 2b3eab3a2b561020aaa4fd836cac72a65914042b

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 217 bytes (217B) 217 bytes (217B) No change
ngx-meta-open-graph.mjs 931 bytes (931B) 931 bytes (931B) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 857 bytes (857B) 857 bytes (857B) No change
ngx-meta-twitter-card.mjs 487 bytes (487B) 487 bytes (487B) No change
Total 6091 bytes (6.0KiB) 6091 bytes (6.0KiB) No change

Copy link

github-actions bot commented Oct 30, 2024

📦 Bundle size (Angular v17)

Git ref: 2b3eab3a2b561020aaa4fd836cac72a65914042b

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 217 bytes (217B) 217 bytes (217B) No change
ngx-meta-open-graph.mjs 931 bytes (931B) 931 bytes (931B) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 857 bytes (857B) 857 bytes (857B) No change
ngx-meta-twitter-card.mjs 487 bytes (487B) 487 bytes (487B) No change
Total 6091 bytes (6.0KiB) 6091 bytes (6.0KiB) No change

Copy link

github-actions bot commented Oct 30, 2024

📦 Bundle size (Angular v15)

Git ref: 2b3eab3a2b561020aaa4fd836cac72a65914042b

Module file Size Base size Difference
ngx-meta-core.mjs 3384 bytes (3.4KiB) 3384 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 206 bytes (206B) 206 bytes (206B) No change
ngx-meta-open-graph.mjs 870 bytes (870B) 870 bytes (870B) No change
ngx-meta-routing.mjs 373 bytes (373B) 373 bytes (373B) No change
ngx-meta-standard.mjs 808 bytes (808B) 808 bytes (808B) No change
ngx-meta-twitter-card.mjs 448 bytes (448B) 448 bytes (448B) No change
Total 6089 bytes (6.0KiB) 6089 bytes (6.0KiB) No change

Copy link

github-actions bot commented Oct 30, 2024

📦 Bundle size (Angular v16)

Git ref: 2b3eab3a2b561020aaa4fd836cac72a65914042b

Module file Size Base size Difference
ngx-meta-core.mjs 3467 bytes (3.4KiB) 3467 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 201 bytes (201B) 201 bytes (201B) No change
ngx-meta-open-graph.mjs 870 bytes (870B) 870 bytes (870B) No change
ngx-meta-routing.mjs 379 bytes (379B) 379 bytes (379B) No change
ngx-meta-standard.mjs 808 bytes (808B) 808 bytes (808B) No change
ngx-meta-twitter-card.mjs 448 bytes (448B) 448 bytes (448B) No change
Total 6173 bytes (6.1KiB) 6173 bytes (6.1KiB) No change

@davidlj95 davidlj95 force-pushed the stacked/build-add-script-to-rehearse-a-release-publish branch from b938588 to 2b3eab3 Compare October 30, 2024 20:04
@davidlj95 davidlj95 enabled auto-merge (squash) October 30, 2024 20:04
@davidlj95 davidlj95 disabled auto-merge October 31, 2024 14:46
@davidlj95 davidlj95 merged commit f6cc1b5 into main Oct 31, 2024
33 checks passed
@davidlj95 davidlj95 deleted the stacked/build-add-script-to-rehearse-a-release-publish branch October 31, 2024 14:46
Copy link

🎉 This PR is included in version 1.0.0-beta.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant