Skip to content

Commit

Permalink
rename default Ids
Browse files Browse the repository at this point in the history
  • Loading branch information
davidkyle committed Oct 23, 2024
1 parent 387062e commit 3d76e8f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ public class ElasticsearchInternalService extends BaseElasticsearchInternalServi
);

public static final int EMBEDDING_MAX_BATCH_SIZE = 10;
public static final String DEFAULT_ELSER_ID = ".elser-2";
public static final String DEFAULT_E5_ID = ".multi-e5-small";
public static final String DEFAULT_ELSER_ID = ".elser-2-elasticsearch";
public static final String DEFAULT_E5_ID = ".multilingual-e5-small-elasticsearch";

private static final Logger logger = LogManager.getLogger(ElasticsearchInternalService.class);
private static final DeprecationLogger DEPRECATION_LOGGER = DeprecationLogger.getLogger(ElasticsearchInternalService.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1561,8 +1561,8 @@ public void testEmbeddingTypeFromTaskTypeAndSettings() {

public void testIsDefaultId() {
var service = createService(mock(Client.class));
assertTrue(service.isDefaultId(".elser-2"));
assertTrue(service.isDefaultId(".multi-e5-small"));
assertTrue(service.isDefaultId(".elser-2-elasticsearch"));
assertTrue(service.isDefaultId(".multilingual-e5-small-elasticsearch"));
assertFalse(service.isDefaultId("foo"));
}

Expand Down

0 comments on commit 3d76e8f

Please sign in to comment.