fix(react): export EmblaViewportRefType from bundle #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjerleke
added
feature request
davidjerleke
requested changes
Jul 21, 2024
There was a problem hiding this comment.
Hi @junlarsen,
Thanks for your contribution! I think these changes make sense. We also need to export it from the index file:
The reason why is because package managers like pnpm have introduced new behavior to the frontend world. For example, pnpm doesn’t allow imports from any other file than the index file, so any imports with paths to specific files will fail.
|
Right, missed that one. I'll get on it tonight :) |
davidjerleke
approved these changes
Jul 21, 2024
|
@junlarsen this is approved. Nicely done 👍🏻. Feel free to squash the commits into a single commit. Otherwise I will do it before merging this PR. |
junlarsen
force-pushed
the
fix/export-react-type
branch
from
e20ce28
to
532541d
Compare
|
Thanks @junlarsen 👍🏻! |
|
@junlarsen your fix has been included in |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David, thanks for your awesome work on Embla!
I recently wrote a small wrapper component around the react plugin and found it would be beneficial to pass around the Embla viewport ref type (for example uses like forwardRef).
This small patch re-exports EmblaViewportRefType from embla-carousel-react. Let me know if there are any questions!