Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds .npmignore #658

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Conversation

smulesoft
Copy link
Contributor

@smulesoft smulesoft commented Jan 29, 2019

The archive generated by npm can be checked with command:

npm pack

For more reference, visit this page

Intended to fix #656

@coveralls
Copy link

coveralls commented Jan 29, 2019

Coverage Status

Coverage remained the same at 92.83% when pulling a23131f on smulesoft:adds-npmignore into b77d7ae on davidjbradshaw:master.

@davidjbradshaw
Copy link
Owner

davidjbradshaw commented Jan 31, 2019

I think we could add the src folder as well to this

@smulesoft
Copy link
Contributor Author

@davidjbradshaw Isn't the src folder needed to include the source code?

@davidjbradshaw
Copy link
Owner

davidjbradshaw commented Jan 31, 2019 via email

@smulesoft
Copy link
Contributor Author

You are right @davidjbradshaw , I just tested and it works for us

emoji-genius

@davidjbradshaw davidjbradshaw merged commit c93fdd7 into davidjbradshaw:master Jan 31, 2019
@davidjbradshaw
Copy link
Owner

Thanks for this

@smulesoft smulesoft deleted the adds-npmignore branch January 31, 2019 16:38
@smulesoft
Copy link
Contributor Author

Thank you david 👍

@smulesoft
Copy link
Contributor Author

Do you know when you can release it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release includes test code
3 participants