Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set scrolling property for iframes to 'auto' #315

Closed
FrancisRussell opened this issue Feb 5, 2016 · 3 comments
Closed

Unable to set scrolling property for iframes to 'auto' #315

FrancisRussell opened this issue Feb 5, 2016 · 3 comments

Comments

@FrancisRussell
Copy link

When scrollbars are requested, setScrolling() sets the scrolling property to 'yes'. It would be nice to have the scrollbars added only when necessary. On browsers like Chrome, Safari and IE, 'yes' is treated the same as 'auto', so they're only added when necessary. Also, 'auto' is typically the default. In Opera though, they'll always be added. Ideally it would be possible to either tell iframe-resizer to set this to 'auto', have 'auto' as the default for scrolling rather than 'yes' or disable iframe-resizer's setting of the scrolling properties entirely.

@FrancisRussell FrancisRussell changed the title Unable to set scolling property for iframes to 'auto' Unable to set scrolling property for iframes to 'auto' Feb 5, 2016
@davidjbradshaw
Copy link
Owner

Would you like to make a PR to add auto as an option?

@FrancisRussell
Copy link
Author

Hi, and sorry for not responding to the first comment - I've been a little overloaded. Given that most browsers treat "yes" the same as "auto" for the scrolling property, I'm inclined just to create a pull request for that change as you originally suggested, unless you think a more sophisticated option would be more useful.

@davidjbradshaw
Copy link
Owner

Well I expect it's only a couple of lines of code to allow the option flag to be true, false, or 'auto'.

Also stupidity busy right now so don't worry about slow replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants