Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-9822: Fix inplace editing #205

Merged

Conversation

sh-csg
Copy link
Contributor

@sh-csg sh-csg commented Jan 4, 2025

Inplace editing is not working right now for (sub-)section titles - this is due to a typo in lib.php.

Steps to reproduce (in Moodle 4.5):

  • Create a course with format_onetopic
  • Create a subsection activity (mod_subsection)
  • Click on the subsection title, type something and press enter
  • An error message will appear

@sh-csg
Copy link
Contributor Author

sh-csg commented Jan 4, 2025

Failing GHA is not related to this PR.

@davidherney davidherney merged commit 96812b0 into davidherney:master Jan 4, 2025
0 of 4 checks passed
@davidherney
Copy link
Owner

Hi @sh-csg...

A typing error... horrible. Thanks for correcting it.

Since that method was no longer used I hadn't tried it again, I'll have to consider several new things now with the sub-sections.

Saludos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants