Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError: speed issue test_os_path_join #1306

Closed
Ikke opened this issue Apr 2, 2019 · 2 comments
Closed

AssertionError: speed issue test_os_path_join #1306

Ikke opened this issue Apr 2, 2019 · 2 comments

Comments

@Ikke
Copy link

Ikke commented Apr 2, 2019

I'm building jedi for Alpine Linux, and run against an AssertionError when running the test suite on aarch64:

assert single_time < time_per_run, message
--
597 | E AssertionError: speed issue <function test_os_path_join at 0xffffb721c6a8>, 0.4082823395729065
598 | E assert 0.4082823395729065 < 0.3

Because aarch64 is not the fastest platform, it can be expected that it perfoms slower. Is this a serious issue, or something we can work around?

Ikke added a commit to Ikke/aports that referenced this issue Apr 2, 2019
The test takes slightly longer on aarch64 then the test allows.

Issue: davidhalter/jedi#1306
@davidhalter
Copy link
Owner

davidhalter commented Apr 5, 2019

It's not a problem at all. The speed tests have some margins, but essentially they are just there to alarm me that something went wrong and the build got significantly slower. It would probably also fail on old hardware.

For now this is a won't fix. Test runners should be "fast" enough. #1059 should make things better. Wait for that :)

@Ikke
Copy link
Author

Ikke commented Apr 5, 2019

Thanks.

For now I have patched the threshold to be a bit higher to get the tests passing.

liske pushed a commit to liske/aports that referenced this issue Apr 7, 2019
The test takes slightly longer on aarch64 then the test allows.

Issue: davidhalter/jedi#1306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants