Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: cover jedi_debug_info #993

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Feb 2, 2020

@blueyed
Copy link
Collaborator Author

blueyed commented Feb 2, 2020

51% at least.. ;)

Fails on py27 due to:

Error when running display_debug_info: Vim(return):Exception TypeError: 'call() takes exactly 1 argument (2 given)' in <jedi._compatibility.finalize object at 0x7f0f8b98e360> ignored

IIRC this might be fixed (in davidhalter/jedi@9fb94bb) with the update (#991).

@davidhalter
Copy link
Owner

BTW: The question is also how long we are going to support Python 2. I have deprecated it in Jedi and I will remove it after a while. I guess most VIM versions (including my old one) come with Python 3 support. Jedi can still deal with Python 2 (for a while), so people could just use :let jedi#force_py_version=2.7 for the time being.

@blueyed
Copy link
Collaborator Author

blueyed commented Feb 2, 2020

@davidhalter IMHO it makes sense to remove it gets into the way, i.e. when we want to add type annotations etc, but then this would be easier after also dropping py35 - so no rush.

@blueyed
Copy link
Collaborator Author

blueyed commented Feb 3, 2020

codecov/project — 51.54% (+3.71%) compared to 18b1a51

@blueyed blueyed merged commit 8d24b83 into davidhalter:master Feb 3, 2020
@blueyed blueyed deleted the cover-jedi_debug_info branch February 3, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants