jedi_vim.get_environment: cache with $VIRTUAL_ENV

[blueyed]

Note that you have to use e.g. :py3 os.environ['VIRTUAL_ENV'] = 'foo'
to update this, :let $VIRTUAL_ENV = 'foo' is not enough (both in
Neovim and Vim).

Ref: davidhalter/jedi#1200

[codecov-io]

Codecov Report

Merging #872 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   27.62%   27.21%   -0.42%     
==========================================
  Files           3        3              
  Lines         619      621       +2     
  Branches      122      122              
==========================================
- Hits          171      169       -2     
- Misses        435      439       +4     
  Partials       13       13

Flag	Coverage Δ
#py27	26.24% <0%> (-0.09%)	⬇️
#py36	24.95% <0%> (-0.41%)	⬇️

Impacted Files	Coverage Δ
pythonx/jedi_vim.py	25.04% <0%> (-0.49%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132d850...3cb0f48. Read the comment docs.

[blueyed]

Re coverage: it appears to not mark anything covered after e.g. vim.eval is used.. :/
Filed neovim/pynvim#354, but am not sure if this is a neovim-python-client problem really.

[davidhalter]

Hmm, I haven't looked at it in detail, but wouldn't the proposed Jedi change of yours be good enough?

[blueyed]

but wouldn't the proposed Jedi change of yours be good enough?

Not really currently, since jedi-vim does caching itself already.

[blueyed]

I think this still makes sense even with the improvement in Jedi, right?
davidhalter/jedi@862f611

[davidhalter]

I think this still makes sense even with the improvement in Jedi, right?

I agree that this still made sense at the time. However with the latest changes it's not necessary anymore, because we do caching.

I'm closing, but feel free to reopen if you think that this is still relevant.