Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete-on-dot: do not trigger with dot in front #859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

complete-on-dot: do not trigger with dot in front #859

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Jul 28, 2018

Fixes #506

blueyed
blueyed commented Jul 28, 2018
View reviewed changes
ftplugin/python/jedi.vim
inoremap <silent> <buffer> . .<C-R>=jedi#complete_string(1)<CR>
function! s:complete_on_dot() abort
" Do not trigger completion if there is a dot before already.
if getline('.')[-2:-2] ==# '.'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems weird, but it is likely the best in Vimscript?!

Copy link
Owner

@davidhalter davidhalter Jul 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just not working if you're not editing at the end. We probably need to also use the cursor position.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, good catch.. :)

@blueyed blueyed mentioned this pull request Jul 28, 2018
Closed
@blueyed blueyed added the bug label Jul 30, 2018
@davidhalter
Copy link
Owner

What do you think about this change? I personally feel like it's obsolete. We used to have weird issues when using multiple dots. But since Jedi got its shit together about this, I think it's pretty much fine. It obviously still tries to do an autocompletion (I still get a -- Omni completion (^O^N^P) Pattern not found), but that's fine IMO.

However if you like this change, I'm happy to merge it. Sorry for keeping it open for so long, we really could have merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhalter davidhalter davidhalter left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

... should not auto-start completion
2 participants
@blueyed @davidhalter