Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts client - initial prototype #12

Merged
merged 10 commits into from
Nov 3, 2016
Merged

ts client - initial prototype #12

merged 10 commits into from
Nov 3, 2016

Conversation

moozzyk
Copy link
Collaborator

@moozzyk moozzyk commented Nov 2, 2016

I have the following list of TODOs:

  • add transport closed event
  • remove fallback as per discussion today
  • unify errors
  • review capturing of this in callbacks/eventhandlers
  • logging
  • convert RpcConnection to Hub
  • detach dispatching from transports/connection
  • enable plugging in custom formatters

@moozzyk
Copy link
Collaborator Author

moozzyk commented Nov 2, 2016

/cc @anurse @davidfowl @DamianEdwards @BrennanConroy

moozzyk and others added 10 commits November 2, 2016 17:09
ts-client WebSockets + JSON
6859d33
@moozzyk
WIP
5663198
WIP
29d859b
Adding longpolling
181053e
Adding ServerSentEvents
466c8d9
WIP:
752f329 
- separating Connection from RpcConnection
- fixing WebSockets transport to work after rewrite
- clean up
Adding transport selection
ce17f0d 
Fixing serverSentEvents transport
Updating the client 'app'
Fixing LongPolling transport
61c527f
Adding error handling
2bbca5e 
Fixing SSE transport on the server
minor fixes
3065c8d
davidfowl
davidfowl reviewed Nov 3, 2016
View reviewed changes
src/Microsoft.AspNetCore.Sockets/ServerSentEvents.cs
@@ -21,6 +21,7 @@ public ServerSentEvents(Connection connection)
context.Response.ContentType = "text/event-stream";
context.Response.Headers["Cache-Control"] = "no-cache";
context.Response.Headers["Content-Encoding"] = "identity";
await context.Response.Body.FlushAsync();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Without that SSE does not quite work - i.e. opened event on EventSource only is sent with the first message,

@moozzyk moozzyk merged commit 3065c8d into master Nov 3, 2016
@moozzyk moozzyk mentioned this pull request Nov 3, 2016
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moozzyk @davidfowl