Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel of phonenumberslite still contains geo data #105

Closed
moggers87 opened this issue Sep 15, 2017 · 2 comments
Closed

wheel of phonenumberslite still contains geo data #105

moggers87 opened this issue Sep 15, 2017 · 2 comments

Comments

@moggers87
Copy link

This can easily be observed by looking at the file sizes of the wheel versus source distribution on pypi: https://pypi.python.org/pypi/phonenumberslite/8.8.1

Downloading each and inspecting them confirms that the wheel contains geodata and the source tarball does not (as should be the case).

@daviddrysdale
Copy link
Owner

Good spot, I'd not noticed that. I think I'm falling foul of wheel issue #147: when I build the lite version it picks up the build detritus from the build of the full version and includes it.

daviddrysdale added a commit that referenced this issue Sep 15, 2017
Otherwise full-build detritus can get bundled into the lite build.
See issue #105.
@daviddrysdale
Copy link
Owner

I'll mark this as closed; the next release should have the smaller wheel (IIRC PyPI doesn't allow changes to existing packages).

Themimitoof pushed a commit to Themimitoof/python-phonenumbers that referenced this issue Sep 10, 2019
Otherwise full-build detritus can get bundled into the lite build.
See issue daviddrysdale#105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants