support multiline CoffeeScript comments #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for multiline CoffeeScript comments.
CoffeeScript comments are now extracted by using
CoffeeScript.helpers.extractAllCommentTokens
in conjunction withCoffeeScript.tokens
(previously we used a regular expression,/^([ \t]*)(.*)\n?/gm
). Although comment tokens have ahere
property, I decided not to use it when I realized that CoffeeScript supports inline###
comments. Instead, we uselocationData.last_line > locationData.first_line
to determine whether a comment spans multiple lines.rewriteCoffee
is now very similar torewriteJs
, at a high level:The only significant difference is that
rewriteJs
parses the source text whereasrewriteCoffee
only lexes it.rewriteJs
now extracts lines from multiline comments withString.prototype.indexOf
andString.prototype.slice
rather thanString.prototype.split
.