added scene_height and scene_width as option #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing some ref
Adding gns3_nodes_inventory and bumping gns3fy usage to 0.3.0
bumping to 1.2.1
Updating to gns3fy 0.4.0
Bumping to v1.2.2
Bumping to version 1.3.0
Adding gns3_node
Bumping to 1.5.0
davidban77
requested changes
Jul 30, 2023
There was a problem hiding this comment.
Thanks for the contribution! It looks pretty straightforward :)
I just have a small comment around default values and if is possible to make this PR against the develop branch so I can cut a new release with it?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added scene_height and scene_width as an option to be set through ansible for large scenes which otherwise fall outside the client default settings of the project.