Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support axum 0.7 #115

Closed
davidBernardWefox opened this issue Nov 28, 2023 · 3 comments
Closed

Upgrade to support axum 0.7 #115

davidBernardWefox opened this issue Nov 28, 2023 · 3 comments

Comments

@davidBernardWefox
Copy link

Update / provide the compatibility matrix of version: axum - middleware - opentelemetry

alexhumphreys added a commit to alexhumphreys/rust-template that referenced this issue Dec 5, 2023
@rakshith-ravi
Copy link

Hey. Just curious - if I were to follow the progress on the upgrade, or help push this forward, what would be the right PR to subscribe to?

@davidB
Copy link
Owner

davidB commented Dec 15, 2023

I started working on it. But I suspend due to

  • axum 0.7 removed the simple gracefully shutdown (see its example and the comment related to hyper-utils)
  • tonic was not upgraded for hyper 1.0 (being able to support multiple version of hyper in the workspace introduce lot of complexity for just a transition period).

PS: the migration of tonic to hyper 1.0 and axum 0.7 could take time, I'll see if something could be done to not block upgrade to axum 0.7

PS: PR are welcomes, I'll push mine as draft.

@davidB
Copy link
Owner

davidB commented Jan 16, 2024

IMHO, half fixed but I close the ticket as a version is available for axum-0.7

@davidB davidB closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants