-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to run one tailed experiments #137
Changes from 1 commit
ad1244b
28a1db6
a064435
92eacb8
a2d7359
bb51bc0
2a85493
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,5 +14,5 @@ def test_binary_treatment(): | |
|
||
def test_get_pvalue(): | ||
analysis_df_full = pd.concat([analysis_df for _ in range(100)]) | ||
analyser = OLSAnalysis() | ||
analyser = OLSAnalysis(hypothesis="left_tailed") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd add a separate test, and I'd test the functionality itself of the p-value transformer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as in, check that it is dividing by 2 or doing the other stuff when necessary |
||
assert analyser.get_pvalue(analysis_df_full) >= 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for your local developement? or is it because of github actions?