Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect nested review counts in v2 scheduler #2

Closed
wants to merge 1 commit into from

Conversation

dae
Copy link

@dae dae commented Jun 11, 2022

This backports f50cd43 from 2.1.41, allowing AnkiDroid to use the backend deck tree code with the V2 scheduler (will follow up with a patch to AnkiDroid)

dae added a commit to ankitects/Anki-Android that referenced this pull request Jun 11, 2022
This requires david-allison/anki#2 to be merged
into a new AnkiDroid backend release before this can be used.
dae added a commit to ankitects/Anki-Android that referenced this pull request Jun 11, 2022
This requires david-allison/anki#2 to be merged
into a new AnkiDroid backend release before this can be used.
dae added a commit to ankitects/Anki-Android that referenced this pull request Jun 11, 2022
This requires david-allison/anki#2 to be merged
into a new AnkiDroid backend release before this can be used.
dae added a commit to ankitects/Anki-Android that referenced this pull request Jun 11, 2022
This requires david-allison/anki#2 to be merged
into a new AnkiDroid backend release before this can be used.
dae added a commit to ankitects/Anki-Android that referenced this pull request Jun 11, 2022
This requires david-allison/anki#2 to be merged
into a new AnkiDroid backend release before this can be used.
Copy link

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@mikehardy
Copy link

Okay, I have no rights in this repo, and running them outside of the ankidroid org is no way to go so:

1- I forked ankitects/anki into ankidroid org
2- I added typical ankidroid org teams to access control for ankidroid/anki (so now we have normal non-single-point-of-failure collaboration up and running)
3- I pulled ankidroid and ankidroid-2-1-34 branches from david-allison/anki repo and pushed them to ankidroid/anki (so now we have all ankidroid-specific changes current as of today in new fork)
4- I posted ankidroid#1 to supercede this, so your work is captured in identical PR, but in a place I can merge it
5- I posted a PR to use new anki fork/branch ref as submodule in Ank-Android-Backend ankidroid/Anki-Android-Backend#199

Next steps will be to merge item 5 above, then merge item 4

Will have to figure out how to publish later

This may be closed.

@dae dae closed this Jun 27, 2022
@dae dae deleted the fix-counts branch June 27, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants