Consume existing mongo.Db, typo fix and some jsHint fixes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ The standard usage, is to just pass an instantiated `MongoStore` instance to the | |||
|
|
|||
| You can also pass several options to the constructor to tweak your session store: | |||
|
|
|||
| * db - The name of the db to use, defaults to: `express-sessions` | |||
| * db - The name of the db to use, defaults to: `express-sessions` Or you can assign an existing mongo.Db instance | |||
There was a problem hiding this comment.
README change to highlight the functionality to consume mongo.Db instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all i will thank you to get time and write this package for community.
I was using this package in one of my app, but i wanted to use existing mongo connection(with replicaset settings), but not found the way to do it with current version, so i added in my stuff to handle existing mongo.Db instance. Also i fixed 2 of the typos and did some jsHint cleaning.
I hope these changes can help improve the current version.
Excuse me if that makes no senses to package.
Thanks