Fix unquoted filepaths #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zetlen @davewasmer Do you need any extra information to move this forward? It's currently blocking an issue on gatsbyjs project. |
|
@wardpeet Hey, thanks for your patience. I'll investigate, but this shouldn't be a big deal. |
alias-mac
pushed a commit
to alias-mac/devcert
that referenced
this pull request
Feb 8, 2024
Bumps [yargs](https://github.com/yargs/yargs) from 15.4.1 to 16.2.0. - [Release notes](https://github.com/yargs/yargs/releases) - [Changelog](https://github.com/yargs/yargs/blob/master/CHANGELOG.md) - [Commits](yargs/yargs@v15.4.1...v16.2.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much guaranteed that there will be issues anytime a file path is passed to a shell command unquoted. If the path contains spaces, then the command will fail. See gatsbyjs/gatsby#16212 (on an older version)
These might be infrequent, but they happen. Most of them have already been fixed since the upgrade to v1.0.0. Here's a couple more.