Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete global ids #51

Closed
wants to merge 16 commits into from

Conversation

leighghunt
Copy link

Updated ApplyEdits to allow deleting with GlobalIds.

A couple of things to note:

  • I've had to comment out a couple of assertions as they seem to generate false negatives. Let me know if you want me to review these again, but seems like a possible issue with REST service. Checking updates/deletes in destination service indicate test is successful.
  • This incorporates my earlier retry-BatchQuery changes, o let me know if you'd like me to resubmit if/when you accept that change, or if you'd like me to isolate it from that change.

@davetimmins
Copy link
Owner

I've added the delete using global IDs in v1.10.0. I decided to omit the retry functionality at the moment as I think it would be more useful for any operation but want to think about the best way to add that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants