Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are small enough to be in a single PR, at least in this case. The changes proposed here are:
LEFT JOIN
inSELECT
queries instead ofWHERE
. This allows exporting articles with missing authors and/or categoriesJoomlaContent::isPublished()
now only returnstrue
if the article was marked asPublished
in Joomla. Previously it would returntrue
forUnpublished
articles as well, but not forArchived
orTrashed
articles, and was used to filter out which articles not to export at all. After this update, all articles will be exported, but those not currentlyPublished
in Joomla will be marked asdraft: true
. Perhaps the filtering logic could be reintroduced, but use some new property.created
date of Joomla articles is now exported asdate
, andmodified
date aslastmod
(previously, onlymodified
date was exported asdate
). I myself actually used thepublish_up
value asdate
field, but that should probably be exported into thepublishDate
field instead. I didn't try that scenario though, so leaving this nuance as-is.*.toml.ftl
templates have been removed.I didn't even look at tests, so it's possible that some are now failing.