Skip to content

Commit

Permalink
Change ScrollView to inherit from ScrollableContainer rather than Widget
Browse files Browse the repository at this point in the history
  • Loading branch information
davep committed Apr 20, 2023
1 parent ee45356 commit fe5f80b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Changed

- Breaking change: standard keyboard scrollable navigation bindings have been moved off `Widget` and onto a new base class for scrollable containers (see also below addition) https://github.com/Textualize/textual/issues/2332
- `ScrollView` now inherits from `Scrollablecontainer` rather than `Widget` https://github.com/Textualize/textual/issues/2332

### Added

Expand Down
4 changes: 2 additions & 2 deletions src/textual/scroll_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@

from rich.console import RenderableType

from .containers import ScrollableContainer
from .geometry import Size
from .widget import Widget


class ScrollView(Widget):
class ScrollView(ScrollableContainer):
"""
A base class for a Widget that handles it's own scrolling (i.e. doesn't rely
on the compositor to render children).
Expand Down

0 comments on commit fe5f80b

Please sign in to comment.